There’s npf interface in ftp-proxy. What if we want to use ftp-proxy with npf. So then we would have to separate ftp-proxy from pf into its own module for maintainability ??
> On 22 Jan 2025, at 1:01 PM, Christoph Badura <b...@bsd.de> wrote: > > On Tue, Jan 07, 2025 at 09:15:41PM +0000, Emmanuel wrote: >> Modified Files: >> src/dist/pf/usr.sbin/ftp-proxy: filter.c ftp-proxy.c >> Log Message: >> clearn up : remove trailing whitespaces > > I think we don't generally do whitespace or style cleanups in source > code imported from external projects. That just makes merging updates > more difficult. > > Admittedly, importing a new version of pf is unlikely. So I would leave > these commits as is. > > --chris Emmanuel