Module Name: src
Committed By: hannken
Date: Mon Dec 30 09:01:35 UTC 2024
Modified Files:
src/sys/ufs/ext2fs: ext2fs_vfsops.c
src/sys/ufs/ffs: ffs_vfsops.c
src/sys/ufs/lfs: lfs_vfsops.c
Log Message:
emove comment "we are always called with the filesystem marked `MPBUSY'."
above some xxx_sync() operations. These operations get called without
any exclusive lock.
This comment appeared with "add quota support" on 1990-05-02.
On 1998/02/18 MNT_MPBUSY disappeared when vfs_busy() was changed from
an exclusive lock to a shared lock.
PR kern/58837 "ffs: Missing locking around fs_fmod/time"
To generate a diff of this commit:
cvs rdiff -u -r1.227 -r1.228 src/sys/ufs/ext2fs/ext2fs_vfsops.c
cvs rdiff -u -r1.382 -r1.383 src/sys/ufs/ffs/ffs_vfsops.c
cvs rdiff -u -r1.382 -r1.383 src/sys/ufs/lfs/lfs_vfsops.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/ufs/ext2fs/ext2fs_vfsops.c
diff -u src/sys/ufs/ext2fs/ext2fs_vfsops.c:1.227 src/sys/ufs/ext2fs/ext2fs_vfsops.c:1.228
--- src/sys/ufs/ext2fs/ext2fs_vfsops.c:1.227 Tue Jul 2 05:02:49 2024
+++ src/sys/ufs/ext2fs/ext2fs_vfsops.c Mon Dec 30 09:01:35 2024
@@ -1,4 +1,4 @@
-/* $NetBSD: ext2fs_vfsops.c,v 1.227 2024/07/02 05:02:49 rin Exp $ */
+/* $NetBSD: ext2fs_vfsops.c,v 1.228 2024/12/30 09:01:35 hannken Exp $ */
/*
* Copyright (c) 1989, 1991, 1993, 1994
@@ -60,7 +60,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ext2fs_vfsops.c,v 1.227 2024/07/02 05:02:49 rin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ext2fs_vfsops.c,v 1.228 2024/12/30 09:01:35 hannken Exp $");
#if defined(_KERNEL_OPT)
#include "opt_compat_netbsd.h"
@@ -961,8 +961,6 @@ ext2fs_sync_selector(void *cl, struct vn
* Go through the disk queues to initiate sandbagged IO;
* go through the inodes to write those that have been modified;
* initiate the writing of the super block if it has been modified.
- *
- * Note: we are always called with the filesystem marked `MPBUSY'.
*/
int
ext2fs_sync(struct mount *mp, int waitfor, kauth_cred_t cred)
Index: src/sys/ufs/ffs/ffs_vfsops.c
diff -u src/sys/ufs/ffs/ffs_vfsops.c:1.382 src/sys/ufs/ffs/ffs_vfsops.c:1.383
--- src/sys/ufs/ffs/ffs_vfsops.c:1.382 Fri Sep 8 23:21:55 2023
+++ src/sys/ufs/ffs/ffs_vfsops.c Mon Dec 30 09:01:35 2024
@@ -1,4 +1,4 @@
-/* $NetBSD: ffs_vfsops.c,v 1.382 2023/09/08 23:21:55 riastradh Exp $ */
+/* $NetBSD: ffs_vfsops.c,v 1.383 2024/12/30 09:01:35 hannken Exp $ */
/*-
* Copyright (c) 2008, 2009 The NetBSD Foundation, Inc.
@@ -61,7 +61,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ffs_vfsops.c,v 1.382 2023/09/08 23:21:55 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ffs_vfsops.c,v 1.383 2024/12/30 09:01:35 hannken Exp $");
#if defined(_KERNEL_OPT)
#include "opt_ffs.h"
@@ -1969,8 +1969,6 @@ ffs_sync_selector(void *cl, struct vnode
* Go through the disk queues to initiate sandbagged IO;
* go through the inodes to write those that have been modified;
* initiate the writing of the super block if it has been modified.
- *
- * Note: we are always called with the filesystem marked `MPBUSY'.
*/
int
ffs_sync(struct mount *mp, int waitfor, kauth_cred_t cred)
Index: src/sys/ufs/lfs/lfs_vfsops.c
diff -u src/sys/ufs/lfs/lfs_vfsops.c:1.382 src/sys/ufs/lfs/lfs_vfsops.c:1.383
--- src/sys/ufs/lfs/lfs_vfsops.c:1.382 Sat Mar 19 13:53:33 2022
+++ src/sys/ufs/lfs/lfs_vfsops.c Mon Dec 30 09:01:35 2024
@@ -1,4 +1,4 @@
-/* $NetBSD: lfs_vfsops.c,v 1.382 2022/03/19 13:53:33 hannken Exp $ */
+/* $NetBSD: lfs_vfsops.c,v 1.383 2024/12/30 09:01:35 hannken Exp $ */
/*-
* Copyright (c) 1999, 2000, 2001, 2002, 2003, 2007, 2007
@@ -61,7 +61,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: lfs_vfsops.c,v 1.382 2022/03/19 13:53:33 hannken Exp $");
+__KERNEL_RCSID(0, "$NetBSD: lfs_vfsops.c,v 1.383 2024/12/30 09:01:35 hannken Exp $");
#if defined(_KERNEL_OPT)
#include "opt_lfs.h"
@@ -1499,8 +1499,6 @@ lfs_statvfs(struct mount *mp, struct sta
* Go through the disk queues to initiate sandbagged IO;
* go through the inodes to write those that have been modified;
* initiate the writing of the super block if it has been modified.
- *
- * Note: we are always called with the filesystem marked `MPBUSY'.
*/
int
lfs_sync(struct mount *mp, int waitfor, kauth_cred_t cred)
