Module Name: src
Committed By: kre
Date: Thu Jul 11 01:58:15 UTC 2024
Modified Files:
src/tests/libexec/ld.elf_so: t_tls_extern.c
Log Message:
Compensate for change in ATF_REQUIRE_MSG
ATF_REQUIRE_MSG() was recently changed so that ATF_REQUIRE_MSG(x = y, ..)
would generate a warning message, as it probably intended to be x == y.
In ATF_REQUIRE_DL() the use is always ATF_REQUIRE_DL(var = dlopen(...), ...)
where the '=' is certainly not intended to be ==, but is instead checking
that the result of dlopen() is not NULL (while also saving it for later).
Alter the definition of ATF_REQUIRE_DL() to make that explicit.
(The s/\t/ / is just for 80 column police avoidance)
To generate a diff of this commit:
cvs rdiff -u -r1.12 -r1.13 src/tests/libexec/ld.elf_so/t_tls_extern.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/tests/libexec/ld.elf_so/t_tls_extern.c
diff -u src/tests/libexec/ld.elf_so/t_tls_extern.c:1.12 src/tests/libexec/ld.elf_so/t_tls_extern.c:1.13
--- src/tests/libexec/ld.elf_so/t_tls_extern.c:1.12 Sun Jun 4 01:24:58 2023
+++ src/tests/libexec/ld.elf_so/t_tls_extern.c Thu Jul 11 01:58:15 2024
@@ -1,4 +1,4 @@
-/* $NetBSD: t_tls_extern.c,v 1.12 2023/06/04 01:24:58 joerg Exp $ */
+/* $NetBSD: t_tls_extern.c,v 1.13 2024/07/11 01:58:15 kre Exp $ */
/*-
* Copyright (c) 2023 The NetBSD Foundation, Inc.
@@ -31,7 +31,7 @@
#include <atf-c.h>
#include <dlfcn.h>
-#define ATF_REQUIRE_DL(x) ATF_REQUIRE_MSG(x, "%s: %s", #x, dlerror())
+#define ATF_REQUIRE_DL(x) ATF_REQUIRE_MSG((x) != NULL, "%s: %s", #x, dlerror())
enum order {
DEF_USE_EAGER,
