Module Name:    src
Committed By:   mrg
Date:           Thu Aug  3 08:00:10 UTC 2023

Modified Files:
        src/external/bsd/iscsi/dist/src/lib: util.c

Log Message:
log a pointer's value before calling free() on it.  avoids technical UB.

found by GCC 12.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/external/bsd/iscsi/dist/src/lib/util.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/external/bsd/iscsi/dist/src/lib/util.c
diff -u src/external/bsd/iscsi/dist/src/lib/util.c:1.4 src/external/bsd/iscsi/dist/src/lib/util.c:1.5
--- src/external/bsd/iscsi/dist/src/lib/util.c:1.4	Thu Oct 24 19:13:25 2013
+++ src/external/bsd/iscsi/dist/src/lib/util.c	Thu Aug  3 08:00:10 2023
@@ -134,15 +134,15 @@ iscsi_malloc(unsigned n)
 void 
 iscsi_free_atomic(void *ptr)
 {
-	(void) free(ptr);
 	iscsi_trace(TRACE_MEM, "iscsi_free_atomic(%p)\n", ptr);
+	(void) free(ptr);
 }
 
 void 
 iscsi_free(void *ptr)
 {
-	(void) free(ptr);
 	iscsi_trace(TRACE_MEM, "iscsi_free(%p)\n", ptr);
+	(void) free(ptr);
 }
 
 /* debugging levels */

Reply via email to