Module Name: src
Committed By: rillig
Date: Tue Feb 14 20:49:09 UTC 2023
Modified Files:
src/usr.bin/make: cond.c
src/usr.bin/make/unit-tests: cond-token-plain.exp cond-token-plain.mk
cond-undef-lint.exp opt-debug-lint.exp
Log Message:
make: don't interpret the return value of Var_Parse
The return value of Var_Parse is largely redundant to the returned
string. The idea behind the type VarParseResult was to migrate all call
sites to checking this return value instead of the returned string, but
that hasn't happened. Instead, the additional type only added more
complexity.
There was a single place where that return value was actually used, when
parsing conditions. And even in that case, ignoring the VarParseResult
added back an error message that previously hid bugs, in the test
cond-token-plain.mk.
Even though these error messages are redundant in the other tests, they
don't hurt as they don't happen often.
To generate a diff of this commit:
cvs rdiff -u -r1.342 -r1.343 src/usr.bin/make/cond.c
cvs rdiff -u -r1.17 -r1.18 src/usr.bin/make/unit-tests/cond-token-plain.exp
cvs rdiff -u -r1.16 -r1.17 src/usr.bin/make/unit-tests/cond-token-plain.mk \
src/usr.bin/make/unit-tests/opt-debug-lint.exp
cvs rdiff -u -r1.4 -r1.5 src/usr.bin/make/unit-tests/cond-undef-lint.exp
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
