Module Name: src
Committed By: nat
Date: Tue Sep 6 02:31:08 UTC 2022
Modified Files:
src/sys/dev/usb: udl.c
Log Message:
Don't hold a spin lock entering usbd_transfer.
This avoids a crash found with LOCKDEBUG.
To generate a diff of this commit:
cvs rdiff -u -r1.32 -r1.33 src/sys/dev/usb/udl.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/usb/udl.c
diff -u src/sys/dev/usb/udl.c:1.32 src/sys/dev/usb/udl.c:1.33
--- src/sys/dev/usb/udl.c:1.32 Tue Sep 6 02:28:35 2022
+++ src/sys/dev/usb/udl.c Tue Sep 6 02:31:08 2022
@@ -1,4 +1,4 @@
-/* $NetBSD: udl.c,v 1.32 2022/09/06 02:28:35 nat Exp $ */
+/* $NetBSD: udl.c,v 1.33 2022/09/06 02:31:08 nat Exp $ */
/*-
* Copyright (c) 2009 FUKAUMI Naoki.
@@ -53,7 +53,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: udl.c,v 1.32 2022/09/06 02:28:35 nat Exp $");
+__KERNEL_RCSID(0, "$NetBSD: udl.c,v 1.33 2022/09/06 02:31:08 nat Exp $");
#ifdef _KERNEL_OPT
#include "opt_usb.h"
@@ -1541,7 +1541,9 @@ udl_cmd_send_async(struct udl_softc *sc)
mutex_enter(&sc->sc_mtx);
usbd_setup_xfer(cmdq->cq_xfer, cmdq, cmdq->cq_buf,
len, 0, USBD_NO_TIMEOUT, udl_cmd_send_async_cb);
+ mutex_exit(&sc->sc_mtx);
error = usbd_transfer(cmdq->cq_xfer);
+ mutex_enter(&sc->sc_mtx);
if (error != USBD_NORMAL_COMPLETION && error != USBD_IN_PROGRESS) {
aprint_error_dev(sc->sc_dev, "%s: %s!\n", __func__,
usbd_errstr(error));
