Module Name: src
Committed By: riastradh
Date: Tue Jul 19 08:22:34 UTC 2022
Modified Files:
src/sys/dev/pci: if_wm.c
Log Message:
wm(4): Use CSR_WRITE_FLUSH, not bus_space_barrier.
The bus space is mapped non-prefetchable and non-cacheable, so there
is no need for bus_space_barrier and it might not even have any
effect -- bus_space_read/write are totally ordered for non-
prefetchable, non-cacheable mappings anyway. Presumably the intent
here was to wait for acknowledgment of the write from the device --
which bus_space_barrier does not guarantee, and which I expect
requires a read transaction as CSR_WRITE_FLUSH performs.
ok msaitoh@, knakahara@
To generate a diff of this commit:
cvs rdiff -u -r1.744 -r1.745 src/sys/dev/pci/if_wm.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
