Module Name:    src
Committed By:   riastradh
Date:           Sun Jun 26 17:53:06 UTC 2022

Modified Files:
        src/sys/external/bsd/drm2/dist/drm/ttm: ttm_tt.c

Log Message:
drm/ttm: Fix potential leak in error branch.

Not likely but let's not leave a rake to trip on.


To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 src/sys/external/bsd/drm2/dist/drm/ttm/ttm_tt.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/external/bsd/drm2/dist/drm/ttm/ttm_tt.c
diff -u src/sys/external/bsd/drm2/dist/drm/ttm/ttm_tt.c:1.18 src/sys/external/bsd/drm2/dist/drm/ttm/ttm_tt.c:1.19
--- src/sys/external/bsd/drm2/dist/drm/ttm/ttm_tt.c:1.18	Sun Dec 19 12:29:16 2021
+++ src/sys/external/bsd/drm2/dist/drm/ttm/ttm_tt.c	Sun Jun 26 17:53:06 2022
@@ -1,4 +1,4 @@
-/*	$NetBSD: ttm_tt.c,v 1.18 2021/12/19 12:29:16 riastradh Exp $	*/
+/*	$NetBSD: ttm_tt.c,v 1.19 2022/06/26 17:53:06 riastradh Exp $	*/
 
 /* SPDX-License-Identifier: GPL-2.0 OR MIT */
 /**************************************************************************
@@ -32,7 +32,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ttm_tt.c,v 1.18 2021/12/19 12:29:16 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ttm_tt.c,v 1.19 2022/06/26 17:53:06 riastradh Exp $");
 
 #define pr_fmt(fmt) "[TTM] " fmt
 
@@ -112,8 +112,11 @@ static int ttm_dma_tt_alloc_page_directo
 
 	/* Create bus DMA map at ttm->dma_address.  */
 	r = ttm_sg_tt_alloc_page_directory(ttm);
-	if (r)
+	if (r) {
+		kvfree(ttm->ttm.pages);
+		ttm->ttm.pages = NULL;
 		return r;
+	}
 
 	/* Success!  */
 	return 0;

Reply via email to