Module Name:    src
Committed By:   riastradh
Date:           Sun May 22 11:39:17 UTC 2022

Modified Files:
        src/sys/opencrypto: cryptodev.c

Log Message:
crypto(4): crypto_freesession should never fail here.

It can only fail if we pass it an invalid sid, which the logic to
maintain the user sessions should not do.  So kassert error=0 here.


To generate a diff of this commit:
cvs rdiff -u -r1.118 -r1.119 src/sys/opencrypto/cryptodev.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/opencrypto/cryptodev.c
diff -u src/sys/opencrypto/cryptodev.c:1.118 src/sys/opencrypto/cryptodev.c:1.119
--- src/sys/opencrypto/cryptodev.c:1.118	Sun May 22 11:34:29 2022
+++ src/sys/opencrypto/cryptodev.c	Sun May 22 11:39:17 2022
@@ -1,4 +1,4 @@
-/*	$NetBSD: cryptodev.c,v 1.118 2022/05/22 11:34:29 riastradh Exp $ */
+/*	$NetBSD: cryptodev.c,v 1.119 2022/05/22 11:39:17 riastradh Exp $ */
 /*	$FreeBSD: src/sys/opencrypto/cryptodev.c,v 1.4.2.4 2003/06/03 00:09:02 sam Exp $	*/
 /*	$OpenBSD: cryptodev.c,v 1.53 2002/07/10 22:21:30 mickey Exp $	*/
 
@@ -64,7 +64,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: cryptodev.c,v 1.118 2022/05/22 11:34:29 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: cryptodev.c,v 1.119 2022/05/22 11:39:17 riastradh Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -1020,6 +1020,7 @@ csefree(struct csession *cse)
 	int error;
 
 	error = crypto_freesession(cse->sid);
+	KASSERTMSG(error == 0, "error=%d", error);
 	if (cse->key)
 		free(cse->key, M_XDATA);
 	if (cse->mackey)

Reply via email to