Module Name: src
Committed By: rillig
Date: Tue Apr 19 22:40:13 UTC 2022
Modified Files:
src/tests/usr.bin/xlint/lint1: msg_132.c msg_132.exp
Log Message:
tests/lint: add test case for integer non-constant expression
Seen in sqlite3.c.
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/tests/usr.bin/xlint/lint1/msg_132.c
cvs rdiff -u -r1.5 -r1.6 src/tests/usr.bin/xlint/lint1/msg_132.exp
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/tests/usr.bin/xlint/lint1/msg_132.c
diff -u src/tests/usr.bin/xlint/lint1/msg_132.c:1.6 src/tests/usr.bin/xlint/lint1/msg_132.c:1.7
--- src/tests/usr.bin/xlint/lint1/msg_132.c:1.6 Wed Aug 25 22:04:52 2021
+++ src/tests/usr.bin/xlint/lint1/msg_132.c Tue Apr 19 22:40:13 2022
@@ -1,4 +1,4 @@
-/* $NetBSD: msg_132.c,v 1.6 2021/08/25 22:04:52 rillig Exp $ */
+/* $NetBSD: msg_132.c,v 1.7 2022/04/19 22:40:13 rillig Exp $ */
# 3 "msg_132.c"
// Test for message: conversion from '%s' to '%s' may lose accuracy [132]
@@ -85,3 +85,18 @@ cover_build_plus_minus(const char *arr,
return arr + idx;
return arr + (unsigned int)idx;
}
+
+int
+non_constant_expression(void)
+{
+ /*
+ * Even though this variable definition looks like a constant, it
+ * does not fall within C's definition of an integer constant
+ * expression. Due to that, lint does not perform constant folding
+ * on the expression built from this variable and thus doesn't know
+ * that the conversion will always succeed.
+ */
+ const int not_a_constant = 8;
+ /* expect+1: warning: conversion from 'unsigned long' to 'int' may lose accuracy [132] */
+ return sizeof(double) + not_a_constant * sizeof(char *);
+}
Index: src/tests/usr.bin/xlint/lint1/msg_132.exp
diff -u src/tests/usr.bin/xlint/lint1/msg_132.exp:1.5 src/tests/usr.bin/xlint/lint1/msg_132.exp:1.6
--- src/tests/usr.bin/xlint/lint1/msg_132.exp:1.5 Wed Aug 25 22:04:52 2021
+++ src/tests/usr.bin/xlint/lint1/msg_132.exp Tue Apr 19 22:40:13 2022
@@ -12,3 +12,4 @@ msg_132.c(55): warning: conversion from
msg_132.c(59): warning: conversion from 'long long' to 'int' may lose accuracy [132]
msg_132.c(85): error: operands of '+' have incompatible types (pointer != double) [107]
msg_132.c(85): warning: function 'cover_build_plus_minus' expects to return value [214]
+msg_132.c(101): warning: conversion from 'unsigned long' to 'int' may lose accuracy [132]
