Module Name: src
Committed By: riastradh
Date: Fri Apr 1 00:21:19 UTC 2022
Modified Files:
src/sys/dev: cgd.c
Log Message:
cgd(4): Remove recently added dependency on adiantum.
While this dependency is technically correct, it triggers a problem
with module initialization for builtin modules that manifests as an
instant crash on boot for x86 (and likely arm) kernels, and that
problem is not trivial to solve immediately. See the top of
sys/crypto/aes/aes_impl.c for a summary of the problem and why it's
tricky.
So as a stop-gap measure, we'll remove this dependency for now; we
can reinstate it later once the underlying problem with module
initialization order is resolved.
Reported-by: syzbot+e9b3550af985b6557...@syzkaller.appspotmail.com
(actually first reported, to my knowledge, by pgoyette@, but this
line tells syzkaller that we fixed the problem)
To generate a diff of this commit:
cvs rdiff -u -r1.143 -r1.144 src/sys/dev/cgd.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/dev/cgd.c
diff -u src/sys/dev/cgd.c:1.143 src/sys/dev/cgd.c:1.144
--- src/sys/dev/cgd.c:1.143 Thu Mar 31 19:30:15 2022
+++ src/sys/dev/cgd.c Fri Apr 1 00:21:19 2022
@@ -1,4 +1,4 @@
-/* $NetBSD: cgd.c,v 1.143 2022/03/31 19:30:15 pgoyette Exp $ */
+/* $NetBSD: cgd.c,v 1.144 2022/04/01 00:21:19 riastradh Exp $ */
/*-
* Copyright (c) 2002 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: cgd.c,v 1.143 2022/03/31 19:30:15 pgoyette Exp $");
+__KERNEL_RCSID(0, "$NetBSD: cgd.c,v 1.144 2022/04/01 00:21:19 riastradh Exp $");
#include <sys/types.h>
#include <sys/param.h>
@@ -1723,7 +1723,7 @@ cgd_selftest(void)
aprint_debug("cgd: self-tests passed\n");
}
-MODULE(MODULE_CLASS_DRIVER, cgd, "adiantum,blowfish,des,dk_subr,bufq_fcfs");
+MODULE(MODULE_CLASS_DRIVER, cgd, "blowfish,des,dk_subr,bufq_fcfs");
#ifdef _MODULE
CFDRIVER_DECL(cgd, DV_DISK, NULL);
