Module Name:    src
Committed By:   riastradh
Date:           Sun Feb 13 13:41:26 UTC 2022

Modified Files:
        src/sys/arch/acorn32/include: lock.h

Log Message:
acorn32: Partial __cpu_simple_lock membar audit.

For __cpu_simple_unlock, __insn_barrier is absolutely required.
Whether we need a stronger memory barrier, I don't know offhand and
I'm not sure what the right architecture manual to consult is -- it's
not clear why this isn't just using the generic arm lock.h.


To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 src/sys/arch/acorn32/include/lock.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/arch/acorn32/include/lock.h
diff -u src/sys/arch/acorn32/include/lock.h:1.9 src/sys/arch/acorn32/include/lock.h:1.10
--- src/sys/arch/acorn32/include/lock.h:1.9	Thu Jan 15 01:11:32 2009
+++ src/sys/arch/acorn32/include/lock.h	Sun Feb 13 13:41:26 2022
@@ -1,4 +1,4 @@
-/*	$NetBSD: lock.h,v 1.9 2009/01/15 01:11:32 pooka Exp $	*/
+/*	$NetBSD: lock.h,v 1.10 2022/02/13 13:41:26 riastradh Exp $	*/
 
 /*-
  * Copyright (c) 2000, 2001 The NetBSD Foundation, Inc.
@@ -82,6 +82,7 @@ static __inline void __attribute__((__un
 __cpu_simple_unlock(__cpu_simple_lock_t *alp)
 {
 
+	__insn_barrier();
 	*alp = __SIMPLELOCK_UNLOCKED;
 }
 

Reply via email to