Module Name: src
Committed By: rillig
Date: Mon Feb 7 02:44:49 UTC 2022
Modified Files:
src/tests/usr.bin/xlint/lint1: msg_041.c msg_041.exp
src/usr.bin/xlint/lint1: decl.c err.c
Log Message:
lint: reword message about bit-field in a union
There is nothing illegal about a bit-field in a union, it is allowed by
C90, C99 and C11.
Fixes PR toolchain/53219.
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/tests/usr.bin/xlint/lint1/msg_041.c \
src/tests/usr.bin/xlint/lint1/msg_041.exp
cvs rdiff -u -r1.243 -r1.244 src/usr.bin/xlint/lint1/decl.c
cvs rdiff -u -r1.151 -r1.152 src/usr.bin/xlint/lint1/err.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/tests/usr.bin/xlint/lint1/msg_041.c
diff -u src/tests/usr.bin/xlint/lint1/msg_041.c:1.3 src/tests/usr.bin/xlint/lint1/msg_041.c:1.4
--- src/tests/usr.bin/xlint/lint1/msg_041.c:1.3 Mon Feb 7 02:39:10 2022
+++ src/tests/usr.bin/xlint/lint1/msg_041.c Mon Feb 7 02:44:49 2022
@@ -1,10 +1,10 @@
-/* $NetBSD: msg_041.c,v 1.3 2022/02/07 02:39:10 rillig Exp $ */
+/* $NetBSD: msg_041.c,v 1.4 2022/02/07 02:44:49 rillig Exp $ */
# 3 "msg_041.c"
-// Test for message: illegal use of bit-field [41]
+// Test for message: bit-field in union is very unusual [41]
union u {
int member;
- /* expect+1: illegal use of bit-field [41] */
+ /* expect+1: bit-field in union is very unusual [41] */
unsigned bit_field : 7;
};
Index: src/tests/usr.bin/xlint/lint1/msg_041.exp
diff -u src/tests/usr.bin/xlint/lint1/msg_041.exp:1.3 src/tests/usr.bin/xlint/lint1/msg_041.exp:1.4
--- src/tests/usr.bin/xlint/lint1/msg_041.exp:1.3 Mon Feb 7 02:39:10 2022
+++ src/tests/usr.bin/xlint/lint1/msg_041.exp Mon Feb 7 02:44:49 2022
@@ -1 +1 @@
-msg_041.c(9): warning: illegal use of bit-field [41]
+msg_041.c(9): warning: bit-field in union is very unusual [41]
Index: src/usr.bin/xlint/lint1/decl.c
diff -u src/usr.bin/xlint/lint1/decl.c:1.243 src/usr.bin/xlint/lint1/decl.c:1.244
--- src/usr.bin/xlint/lint1/decl.c:1.243 Wed Dec 22 14:25:35 2021
+++ src/usr.bin/xlint/lint1/decl.c Mon Feb 7 02:44:49 2022
@@ -1,4 +1,4 @@
-/* $NetBSD: decl.c,v 1.243 2021/12/22 14:25:35 rillig Exp $ */
+/* $NetBSD: decl.c,v 1.244 2022/02/07 02:44:49 rillig Exp $ */
/*
* Copyright (c) 1996 Christopher G. Demetriou. All Rights Reserved.
@@ -38,7 +38,7 @@
#include <sys/cdefs.h>
#if defined(__RCSID) && !defined(lint)
-__RCSID("$NetBSD: decl.c,v 1.243 2021/12/22 14:25:35 rillig Exp $");
+__RCSID("$NetBSD: decl.c,v 1.244 2022/02/07 02:44:49 rillig Exp $");
#endif
#include <sys/param.h>
@@ -1134,7 +1134,7 @@ declare_bit_field(sym_t *dsym, tspec_t *
tp->t_flen = size_in_bits(t);
}
if (dsym->s_scl == MOU) {
- /* illegal use of bit-field */
+ /* bit-field in union is very unusual */
warning(41);
dsym->s_type->t_bitfield = false;
dsym->s_bitfield = false;
Index: src/usr.bin/xlint/lint1/err.c
diff -u src/usr.bin/xlint/lint1/err.c:1.151 src/usr.bin/xlint/lint1/err.c:1.152
--- src/usr.bin/xlint/lint1/err.c:1.151 Wed Dec 22 14:25:35 2021
+++ src/usr.bin/xlint/lint1/err.c Mon Feb 7 02:44:49 2022
@@ -1,4 +1,4 @@
-/* $NetBSD: err.c,v 1.151 2021/12/22 14:25:35 rillig Exp $ */
+/* $NetBSD: err.c,v 1.152 2022/02/07 02:44:49 rillig Exp $ */
/*
* Copyright (c) 1994, 1995 Jochen Pohl
@@ -37,7 +37,7 @@
#include <sys/cdefs.h>
#if defined(__RCSID) && !defined(lint)
-__RCSID("$NetBSD: err.c,v 1.151 2021/12/22 14:25:35 rillig Exp $");
+__RCSID("$NetBSD: err.c,v 1.152 2022/02/07 02:44:49 rillig Exp $");
#endif
#include <sys/types.h>
@@ -95,7 +95,7 @@ const char *const msgs[] = {
"function illegal in structure or union", /* 38 */
"zero sized array in struct is a C99 extension: %s", /* 39 */
"unknown size: %s", /* 40 */
- "illegal use of bit-field", /* 41 */
+ "bit-field in union is very unusual", /* 41 */
"forward reference to enum type", /* 42 */
"redefinition hides earlier one: %s", /* 43 */
"declaration introduces new type in ANSI C: %s %s", /* 44 */