> Date: Sat, 5 Feb 2022 22:47:30 +0100 > From: Tobias Nygren <t...@netbsd.org> > > On Sat, 5 Feb 2022 15:17:40 +0000 > Martin Husemann <mar...@netbsd.org> wrote: > > > Modified Files: > > src/sys/kern: subr_autoconf.c > > > > Log Message: > > cfdriver_iattr_count() is only used in a KASSERT, so #ifdef DIAGNOSTIC it. > > This doesn't seem to work as intended. > In a kernel with "no options DIAGNOSTIC" I now get: > > /work/src/sys/kern/subr_autoconf.c: In function 'config_search_internal': > /work/src/sys/kern/subr_autoconf.c:1149:3: error: implicit declaration of > function 'cfdriver_iattr_count' [-Werror=implicit-function-declaration]
I guess we need to decorate cfdriver_iattr_count with __diagused. (Point of the KASSERT change the other month was to eliminate most of these `oops I forgot to try a DIAGNOSTIC / !DIAGNOSTIC build' problems and reduce #ifdefs; thanks, clang...)
