Module Name:    src
Committed By:   riastradh
Date:           Sun Dec 19 12:21:10 UTC 2021

Modified Files:
        src/sys/external/bsd/drm2/dist/drm/amd/powerplay: amdgpu_renoir_ppt.c

Log Message:
amdgpu: amdgpu_renoir_ppt.c

This abuses snprintf with SIZE_MAX as a substitute for sprintf, which
would be super-sketchy, except this code is all dead because it's
only reached via sysfs stuff that isn't wired up in NetBSD.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 \
    src/sys/external/bsd/drm2/dist/drm/amd/powerplay/amdgpu_renoir_ppt.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/external/bsd/drm2/dist/drm/amd/powerplay/amdgpu_renoir_ppt.c
diff -u src/sys/external/bsd/drm2/dist/drm/amd/powerplay/amdgpu_renoir_ppt.c:1.2 src/sys/external/bsd/drm2/dist/drm/amd/powerplay/amdgpu_renoir_ppt.c:1.3
--- src/sys/external/bsd/drm2/dist/drm/amd/powerplay/amdgpu_renoir_ppt.c:1.2	Sat Dec 18 23:45:26 2021
+++ src/sys/external/bsd/drm2/dist/drm/amd/powerplay/amdgpu_renoir_ppt.c	Sun Dec 19 12:21:10 2021
@@ -1,4 +1,4 @@
-/*	$NetBSD: amdgpu_renoir_ppt.c,v 1.2 2021/12/18 23:45:26 riastradh Exp $	*/
+/*	$NetBSD: amdgpu_renoir_ppt.c,v 1.3 2021/12/19 12:21:10 riastradh Exp $	*/
 
 /*
  * Copyright 2019 Advanced Micro Devices, Inc.
@@ -24,7 +24,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: amdgpu_renoir_ppt.c,v 1.2 2021/12/18 23:45:26 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: amdgpu_renoir_ppt.c,v 1.3 2021/12/19 12:21:10 riastradh Exp $");
 
 #include "amdgpu.h"
 #include "amdgpu_smu.h"
@@ -270,12 +270,12 @@ static int renoir_print_clk_levels(struc
 			else
 				i = 1;
 
-			size += sprintf(buf + size, "0: %uMhz %s\n", min,
+			size += snprintf(buf + size, SIZE_MAX/*XXX*/, "0: %uMhz %s\n", min,
 					i == 0 ? "*" : "");
-			size += sprintf(buf + size, "1: %uMhz %s\n",
+			size += snprintf(buf + size, SIZE_MAX/*XXX*/, "1: %uMhz %s\n",
 					i == 1 ? cur_value : RENOIR_UMD_PSTATE_GFXCLK,
 					i == 1 ? "*" : "");
-			size += sprintf(buf + size, "2: %uMhz %s\n", max,
+			size += snprintf(buf + size, SIZE_MAX/*XXX*/, "2: %uMhz %s\n", max,
 					i == 2 ? "*" : "");
 		}
 		return size;
@@ -301,7 +301,7 @@ static int renoir_print_clk_levels(struc
 
 	for (i = 0; i < count; i++) {
 		GET_DPM_CUR_FREQ(clk_table, clk_type, i, value);
-		size += sprintf(buf + size, "%d: %uMhz %s\n", i, value,
+		size += snprintf(buf + size, SIZE_MAX/*XXX*/, "%d: %uMhz %s\n", i, value,
 				cur_value == value ? "*" : "");
 	}
 
@@ -851,7 +851,7 @@ static int renoir_get_power_profile_mode
 		if (workload_type < 0)
 			continue;
 
-		size += sprintf(buf + size, "%2d %14s%s\n",
+		size += snprintf(buf + size, SIZE_MAX/*XXX*/, "%2d %14s%s\n",
 			i, profile_name[i], (i == smu->power_profile_mode) ? "*" : " ");
 	}
 

Reply via email to