On 22.05.2021 00:15, matthew green wrote:
"Roland Illig" writes:
Module Name: xsrc
Committed By: rillig
Date: Fri May 21 19:09:50 UTC 2021
Modified Files:
xsrc/external/mit/xf86-video-nv/dist/src: nv_setup.c
Log Message:
xf86-video-nv: fix Clang build on amd64, i386, macppc
xsrc/external/mit/xf86-video-nv/dist/src/nv_setup.c:258:49: error:
passing 'char *' to parameter of type 'Uchar *' (aka 'unsigned char *')
converts between pointers to integer types with different sign
[-Werror,-Wpointer-sign]
tmp = xf86InterpretEEDID(pScrn->scrnIndex, buffer);
i would rather fix these sorts of issues with -Wno-* in the
relevant makefiles than patching 3rd party code where the
change doesn't really matter (like this one.)
Thanks for the reminder, I should have really considered this approach
before committing my change.
I reviewed my change again, and adding a -Wno-something option would not
be appropriate in this case. The whole block in which I did the patch
was added as a difference to the upstream code.
cvs diff -rxf86-video-nv-2-1-21 -rHEAD \
external/mit/xf86-video-nv/dist/src/nv_setup.c
Therefore I'd like to leave everything as it is right now.
Roland
