>On 24/09/2020 10:04, Ryo Shimizu wrote: >> Module Name: src >> Committed By: ryo >> Date: Thu Sep 24 09:04:38 UTC 2020 >> >> Modified Files: >> src/sys/arch/aarch64/aarch64: bus_space_asm_generic.S >> >> Log Message: >> fix bugs in *_bs_rm_8_swap(). it was only reading 4 bytes, not 8 bytes. > >I think there's another one that needs fixing... > >Nick
>Index: sys/arch/aarch64/aarch64/bus_space_asm_generic.S >=================================================================== >RCS file: /cvsroot/src/sys/arch/aarch64/aarch64/bus_space_asm_generic.S,v >retrieving revision 1.3 >diff -u -p -r1.3 bus_space_asm_generic.S >--- sys/arch/aarch64/aarch64/bus_space_asm_generic.S 24 Sep 2020 09:04:38 >-0000 1.3 >+++ sys/arch/aarch64/aarch64/bus_space_asm_generic.S 24 Sep 2020 10:11:18 >-0000 >@@ -225,7 +225,7 @@ ENTRY_NP(\funcname\()_bs_rm_4_swap) > ldr w8, [x0, #BS_STRIDE] > lsl x8, x2, x8 /* offset <<= tag->bs_stride */ > 1: >- ldrh w9, [x1, x8] >+ ldr w9, [x1, x8] > subs x4, x4, #1 /* count-- */ > rev w9, w9 > str w9, [x3], #4 Ahhh, right. I fixed this too. Thanks again. -- ryo shimizu
