Module Name: src
Committed By: maxv
Date: Sun Sep 8 07:00:20 UTC 2019
Modified Files:
src/sys/kern: sys_sig.c
src/sys/sys: signalvar.h
Log Message:
Introduce sigaction_copy(), to copy sigaction structures without padding,
and use it in sigaction1(). This is to fix info leaks all at once in the
signal functions.
To generate a diff of this commit:
cvs rdiff -u -r1.47 -r1.48 src/sys/kern/sys_sig.c
cvs rdiff -u -r1.93 -r1.94 src/sys/sys/signalvar.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/kern/sys_sig.c
diff -u src/sys/kern/sys_sig.c:1.47 src/sys/kern/sys_sig.c:1.48
--- src/sys/kern/sys_sig.c:1.47 Sat Dec 1 14:05:33 2018
+++ src/sys/kern/sys_sig.c Sun Sep 8 07:00:20 2019
@@ -1,4 +1,4 @@
-/* $NetBSD: sys_sig.c,v 1.47 2018/12/01 14:05:33 maxv Exp $ */
+/* $NetBSD: sys_sig.c,v 1.48 2019/09/08 07:00:20 maxv Exp $ */
/*-
* Copyright (c) 2006, 2007, 2008 The NetBSD Foundation, Inc.
@@ -66,7 +66,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: sys_sig.c,v 1.47 2018/12/01 14:05:33 maxv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: sys_sig.c,v 1.48 2019/09/08 07:00:20 maxv Exp $");
#include "opt_dtrace.h"
@@ -466,7 +466,7 @@ sigaction1(struct lwp *l, int signum, co
ps = p->p_sigacts;
if (osa)
- *osa = SIGACTION_PS(ps, signum);
+ sigaction_copy(osa, &SIGACTION_PS(ps, signum));
if (!nsa)
goto out;
@@ -476,7 +476,7 @@ sigaction1(struct lwp *l, int signum, co
goto out;
}
- SIGACTION_PS(ps, signum) = *nsa;
+ sigaction_copy(&SIGACTION_PS(ps, signum), nsa);
ps->sa_sigdesc[signum].sd_tramp = tramp;
ps->sa_sigdesc[signum].sd_vers = vers;
sigminusset(&sigcantmask, &SIGACTION_PS(ps, signum).sa_mask);
Index: src/sys/sys/signalvar.h
diff -u src/sys/sys/signalvar.h:1.93 src/sys/sys/signalvar.h:1.94
--- src/sys/sys/signalvar.h:1.93 Fri May 3 22:34:21 2019
+++ src/sys/sys/signalvar.h Sun Sep 8 07:00:20 2019
@@ -1,4 +1,4 @@
-/* $NetBSD: signalvar.h,v 1.93 2019/05/03 22:34:21 kamil Exp $ */
+/* $NetBSD: signalvar.h,v 1.94 2019/09/08 07:00:20 maxv Exp $ */
/*
* Copyright (c) 1991, 1993
@@ -93,6 +93,18 @@ struct sigctx {
#define SIGACTION_PS(ps, sig) (ps->sa_sigdesc[(sig)].sd_sigact)
/*
+ * Copy a sigaction structure without padding.
+ */
+static __inline void
+sigaction_copy(struct sigaction *dst, const struct sigaction *src)
+{
+ memset(dst, 0, sizeof(*dst));
+ dst->_sa_u._sa_handler = src->_sa_u._sa_handler;
+ memcpy(&dst->sa_mask, &src->sa_mask, sizeof(dst->sa_mask));
+ dst->sa_flags = src->sa_flags;
+}
+
+/*
* Signal properties and actions.
* The array below categorizes the signals and their default actions
* according to the following properties:
