Module Name: src Committed By: maxv Date: Fri Aug 23 08:01:43 UTC 2019
Modified Files: src/sys/compat/linux/common: linux_misc.c src/sys/compat/linux32/common: linux32_sysinfo.c Log Message: Fix info leaks in sysinfo(). To generate a diff of this commit: cvs rdiff -u -r1.242 -r1.243 src/sys/compat/linux/common/linux_misc.c cvs rdiff -u -r1.7 -r1.8 src/sys/compat/linux32/common/linux32_sysinfo.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Modified files: Index: src/sys/compat/linux/common/linux_misc.c diff -u src/sys/compat/linux/common/linux_misc.c:1.242 src/sys/compat/linux/common/linux_misc.c:1.243 --- src/sys/compat/linux/common/linux_misc.c:1.242 Fri Aug 23 07:53:36 2019 +++ src/sys/compat/linux/common/linux_misc.c Fri Aug 23 08:01:42 2019 @@ -1,4 +1,4 @@ -/* $NetBSD: linux_misc.c,v 1.242 2019/08/23 07:53:36 maxv Exp $ */ +/* $NetBSD: linux_misc.c,v 1.243 2019/08/23 08:01:42 maxv Exp $ */ /*- * Copyright (c) 1995, 1998, 1999, 2008 The NetBSD Foundation, Inc. @@ -57,7 +57,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: linux_misc.c,v 1.242 2019/08/23 07:53:36 maxv Exp $"); +__KERNEL_RCSID(0, "$NetBSD: linux_misc.c,v 1.243 2019/08/23 08:01:42 maxv Exp $"); #include <sys/param.h> #include <sys/systm.h> @@ -1347,6 +1347,7 @@ linux_sys_sysinfo(struct lwp *l, const s struct linux_sysinfo si; struct loadavg *la; + memset(&si, 0, sizeof(si)); si.uptime = time_uptime; la = &averunnable; si.loads[0] = la->ldavg[0] * LINUX_SYSINFO_LOADS_SCALE / la->fscale; Index: src/sys/compat/linux32/common/linux32_sysinfo.c diff -u src/sys/compat/linux32/common/linux32_sysinfo.c:1.7 src/sys/compat/linux32/common/linux32_sysinfo.c:1.8 --- src/sys/compat/linux32/common/linux32_sysinfo.c:1.7 Wed Nov 19 18:36:04 2008 +++ src/sys/compat/linux32/common/linux32_sysinfo.c Fri Aug 23 08:01:43 2019 @@ -1,4 +1,4 @@ -/* $NetBSD: linux32_sysinfo.c,v 1.7 2008/11/19 18:36:04 ad Exp $ */ +/* $NetBSD: linux32_sysinfo.c,v 1.8 2019/08/23 08:01:43 maxv Exp $ */ /*- * Copyright (c) 2006 Emmanuel Dreyfus, all rights reserved. @@ -33,7 +33,7 @@ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: linux32_sysinfo.c,v 1.7 2008/11/19 18:36:04 ad Exp $"); +__KERNEL_RCSID(0, "$NetBSD: linux32_sysinfo.c,v 1.8 2019/08/23 08:01:43 maxv Exp $"); #include <sys/types.h> #include <sys/param.h> @@ -70,6 +70,7 @@ linux32_sys_sysinfo(struct lwp *l, const struct linux32_sysinfo si; struct loadavg *la; + memset(&si, 0, sizeof(si)); si.uptime = time_uptime; la = &averunnable; si.loads[0] = la->ldavg[0] * LINUX_SYSINFO_LOADS_SCALE / la->fscale;