> It still works on NetBSD-4 kernels (if it doesn't, it's not caused by > this change). > > The only difference is that it will print '?' for (LS)DEAD process > (short-lived state).
right - that is what i am wanting not to break. > sysstat ps.c has this change for a long time now. > > How about this change: > > Index: bin/ps/print.c > #ifdef LSDEAD > case LSDEAD: > +#else > + case 6: > #endif gross magic numbers! :) please use something like #include <sys/lwp.h> .. /* pre-NetBSD 5.x support. */ #ifndef LSDEAD #define LSDEAD 6 #endif so at least it's not magic any more. might be nice to also add a note to lwp.h that this value shouldn't be re-used (it is still there so there's an implication already, but explicitly stating it seems better.) thanks.
