Module Name:    src
Committed By:   kre
Date:           Sun May 12 11:55:47 UTC 2019

Modified Files:
        src/etc/rc.d: smtoff

Log Message:
I should know better!   Don't rely upon the way the shell implements
pipes.   Skip the "error" printf from GetSmtId() as there is no easy
portable way to avoid it occurring (there are complicated ways) - but
we don't need it, there is no logical difference between "error" and ""
so just use the latter (if we get an ID, good, if there is nothing, then
there is none - saying 'error' does not mean anything.)


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/etc/rc.d/smtoff

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/etc/rc.d/smtoff
diff -u src/etc/rc.d/smtoff:1.2 src/etc/rc.d/smtoff:1.3
--- src/etc/rc.d/smtoff:1.2	Sun May 12 00:24:03 2019
+++ src/etc/rc.d/smtoff	Sun May 12 11:55:47 2019
@@ -1,6 +1,6 @@
 #!/bin/sh
 #
-# $NetBSD: smtoff,v 1.2 2019/05/12 00:24:03 kre Exp $
+# $NetBSD: smtoff,v 1.3 2019/05/12 11:55:47 kre Exp $
 #
 # Public Domain.
 #
@@ -44,7 +44,6 @@ GetSmtId() {
 			;;
 		esac
 	done
-	printf "error"
 }
 
 #
@@ -75,7 +74,7 @@ smtoff_start()
 		smtid=$(GetSmtId "$i" 2>/dev/null)
 
 		case "$smtid" in
-		error)			# Didn't get the ID? Then maybe no SMT.
+		'')			# Didn't get the ID? Then maybe no SMT.
 			;;
 
 		0)			# The first thread is never disabled.

Reply via email to