On Thu, May 09, 2019 at 16:48:31 +0000, Ryo Shimizu wrote: > Module Name: src > Committed By: ryo > Date: Thu May 9 16:48:31 UTC 2019 > > Modified Files: > src/sys/arch/sh3/sh3: db_trace.c > > Log Message: > fix backtrace. it was broken. > - use db_read_bytes() to avoid faults. > - quite a few functions do not use frame pointers, > therefore always detect stack depth without a frame pointer. > however, since the framepointer(=r14) is used as a trapframe, > the code to detect the frame pointer is still needed. > - dump the contents of trapframe during backtracing. > - KNF
It's a bit unfortunate that this commit lumps together semantic changes and purely cosmetic stuff (like print() instead of (*print)()), which clutters the diff and makes the former less obvious. -uwe