> "Chuck Silvers" <c...@netbsd.org> wrote: > >Module Name: src > >Committed By: chs > >Date: Mon May 28 21:05:12 UTC 2018 > > > >Modified Files: > [snip] > > > src/usr.bin/kdump: Makefile.ioctl-c mkioctls > > [snip] > > Building with clang and MKDTRACE=no, MKCTF=no, I get: > > In file included from kdump-ioctl.c:23: > In file included from /u1/src/sys/net/if.h:82: > /u1/src/sys/sys/mutex.h:155:23: error: redefinition of typedef 'kmutex_t' is > a C > 11 feature [-Werror,-Wtypedef-redefinition] > typedef struct kmutex kmutex_t; > ^ > kdump-ioctl.c:10:23: note: previous definition is here > typedef struct kmutex kmutex_t;
is there any reason we can't just include sys/mutex.h here, instead of this hack? i tried, it works for ctf and noctf builds for me. .mrg.
