Date: Sat, 31 Mar 2018 03:07:29 +0000
From: Taylor R Campbell <campbell+netbsd-source-change...@mumble.net>
Message-ID: <20180331030950.2325d60...@jupiter.mumble.net>
| but a passive observer can't tell the difference between
| one colleague joshing another and someone saying `you're an idiot and
| I cleaned up your mess'.
I totally agree with this - and it is worse when included in commit logs
wherte it will remain, visible, and actually viewed, forever (unlike even
in a mailing list, which while archived forever, somewhere, usually
falls quickly out of view.)
If you feel the need to (in a friendly, or not-so way) to make sure the
developer who got things wrong knows about it, send e-mail. That's
probably a good idea in any case, their view on how to fix it might be
different than yours. If you need a fix quickly, make it in your local
tree - it is not required that all changes be committed the instant you
finish typing them! If you think it likely that others might be seeing
the same problem, send your fix to the appropriate mailing list.
If whoever broke things then doesn't fix it, or ask you to go ahead and
commit your fix, within a reasonable time, then the fix can just be
committed (but by this time, the use for a "hi xxx" will have long since
passed).
kre
