On 17/04/2017 11:41, Manuel Bouyer wrote:
On Mon, Apr 17, 2017 at 07:19:28AM +0000, Maya Rashish wrote:
Module Name: src
Committed By: maya
Date: Mon Apr 17 07:19:28 UTC 2017
Modified Files:
src/sys/arch/amd64/conf: XEN3_DOM0
src/sys/arch/i386/conf: XEN3_DOM0
Log Message:
Uncomment MULTIPROCESSOR in dom0 kernels
Are you sure it's OK ?
It's not clear if the backend drivers, and especially the xenstore,
event channels and grant table stuff, are MP safe (I'm almost sure they
are not). There's still some splfoo()/splx() use there.
At minimum we should KASSERT() that the kernel lock is held here.
I've been using this for > 4 months without a single crash. I know it is
not definite proof it is actually fine, but it sure works great on my
laptop here: Lenovo ThinkPad T440s with pkgsrc 2016Q1 (with security
patches) on netbsd-7 and Xen 4.5, with instances of Linux, FreeBSD and
OpenBSD as DOMU.
The only concern I could observe was some lost keyboard interrupts under
heavy CPU load - but it may not even be related.
Cheers,
--
khorben