matthew green writes: > "Roy Marples" writes: > > Module Name: src > > Committed By: roy > > Date: Wed Sep 21 13:32:27 UTC 2016 > > > > Modified Files: > > src/include: ifaddrs.h > > > > Log Message: > > Add ifa_addrflags to ifaddrs (forgot to commit this file, thanks Ryo!) > > this change (and all the prior ones that need this too) don't seem to > have been done properly. > > getifaddrs(3) at the very least needs to be versioned, but i'm not > really even sure that you can make this change so easily. now any > 3rd party library code will fail unless explicitly updated to > understand this netbsd change and provide different versions. > > please revert these changes and bring it up on tech-kern/tech-net.
roy pointed out privately that getifaddrs() returns a pointer and should be ok with this change. however, there's still a build issue in libsanitizer to fix due to the changed structure size. .mr.
