On Mon, Nov 17, 2014 at 6:58 AM, matthew green <m...@eterna.com.au> wrote: > > "Ryota Ozaki" writes: >> Module Name: src >> Committed By: ozaki-r >> Date: Sun Nov 16 16:20:01 UTC 2014 >> >> Modified Files: >> src/sys/arch/x86/pci: fwhrng.c >> src/sys/arch/x86/x86: via_padlock.c >> src/sys/dev/bluetooth: bcsp.c btkbd.c >> src/sys/dev/ic: nslm7x.c >> src/sys/dev/ir: irframe_tty.c >> src/sys/dev/isa: aps.c >> src/sys/dev/pci: pccbb.c >> src/sys/dev/pcmcia: btbc.c >> src/sys/dev/sdmmc: sdmmc.c >> src/sys/dev/wscons: wskbd.c >> src/sys/net: if_ecosubr.c >> >> Log Message: >> Replace callout_stop with callout_halt >> >> In order to call callout_destroy for a callout safely, we have to ensure >> the function of the callout is not running and pending. To do so, we should >> use callout_halt, not callout_stop. >> >> Discussed with martin@ and riastradh@. > > thanks. it might be nice if callout(9) was expanded to specifically > warn against using callout_stop() before callout_destroy().
Okay, will do. > > i suspect many of these should be pulled up to -5 and -6. I can work on pullup-6 and pullup-7 but I'd appreciate it if someone does pullup-5 because I have no netbsd-5 tree in my local machine. Anyway another patch is under review so that please wait for the patch committed :) ozaki-r > > > .mrg.
