On 09/22/14 11:10, Reinoud Zandijk wrote:
Hi :)
On Sun, Sep 21, 2014 at 01:02:24PM -0400, Christos Zoulas wrote:
Module Name: src
Committed By: christos
Date: Sun Sep 21 17:02:24 UTC 2014
Modified Files:
src/sys/dev/usb: stuirda.c
Log Message:
remove stray return
...
@@ -175,7 +175,6 @@ stuirda_fwload(struct uirda_softc *sc) {
if (rc) {
printf("%s: Cannot load firmware\n",
device_xname(sc->sc_dev));
- return 0;
return rc;
}
fwsize = firmware_get_size(fh);
I'd say this does change the code, since rc is not zero at this point. So is
it really stray? Why was the `return 0' inserted? Or was it your own code?
With regards,
Reinoud
Look like a day #1 bug to me.
Nick
