On Fri, 12 Sep 2014, Roy Marples wrote:
Modified Files:
src/usr.sbin/sysinst: net.c
+ /*
+ * Start dhcpcd quietly and in master mode, but restrict
+ * it to our interface
+ */
+ add_rc_conf("dhcpcd=YES\n");
+ add_rc_conf("dhcpcd_flags=\"-qM %s\"\n", net_dev);
This setting of dhcpcd_flags in /etc/rc.conf will restrict dhcpcd
to only one interface. That might be what people want during the
installation process, but it's not always what they want during
future operations. For example, if I install on a laptop over a
wired ethernet interface, I nevertheless want dhcpcd to work on
the wifi interface later.
I suspect that a more appropriate default would be for dhcpcd to
run on all appropriate interfaces, unless the user deliberately
restricts it. If you do want to restrict it by default, then
please also write a comment to rc.conf to explain the consequences
of this setting. In a hypothetical future where sysinst has a
simple mode and an expert mode, I think simple mode should just
let dhcpcd run on all interfaces, and expert mode should let the
user choose a set of interfaces.
Also, should we add -M to dhcpcd_flags in etc/defaults/rc.conf?
Users typically customise those variables by copying the default
settings from /etc/defaults/rc.conf to /etc/rc.conf and then
adding additional options, so it's helpful if -M is already there
before the user adds their own restricted list of interface names.
--apb (Alan Barrett)