On Thu, Dec 05, 2013 at 10:55:35AM -0500, Christos Zoulas wrote: > Modified Files: > src/sys/net: bpf.c > > Log Message: > It is silly to kill the system when an interface failed to clear > promiscuous mode. Some return EINVAL when they are dying, but > others like USB return EIO. Downgrade to a DIAGNOSTIC printf. Same > should be done for the malloc/NOWAIT, but this is rarely hit.
Having an interface unexpectedly in promiscuous mode tends to cause panic()-like behavior in operators and sysadmins, so it's not clear if this is actually an improvement. :-) I think the printout should be unconditional, and rather than "ifpromisc failed" it should say "bpf: failed to turn off promiscuous mode on %s" with the interface name. -- David A. Holland dholl...@netbsd.org
