On Sep 11, 2012, at 11:19 PM, Emmanuel Dreyfus wrote: > Matt Thomas <m...@3am-software.com> wrote: > >> Only those ports which reserve a register in mcontext for the TCB >> pointer should define _UC_TLSBASE. Otherwise _UC_TLSBASE has no >> meaning and thus should not be defined. > > Well, we have the choice between: > - define it and keeep it unused > - not define it add add #ifdef in libpthread and tests > > I chose the second alternative, an unused #ifdef for a simplier code
In this case, I would prefer an #ifdef _UC_TLSBASE is an MD thing. Defining it unconditionally bloats things. For instance, if _UC_TLSBASE isn't defined, pthread_setcontext doesn't need to do anything except call setcontext. That's a win.
