On Sun, Jul 08, 2012 at 01:21:12AM +0000, Mindaugas Rasiukevicius wrote: > Module Name: src > Committed By: rmind > Date: Sun Jul 8 01:21:12 UTC 2012 > > Modified Files: > src/common/lib/libc: Makefile.inc > src/lib/libc: shlib_version > src/lib/libc/hash: Makefile.inc > Added Files: > src/common/lib/libc/hash/murmurhash: murmurhash.c > > Log Message: > Add MurmurHash2 -- a non-cryptographic hash function by Austin Appleby. > The code is taken from the upstream and is in the public domain. > > OK christos@
There are a number of issues with this. First of all, it pollutes the global namespace and can't be used safely from libc the way it is done. Second, I don't really like adding a special purpose name of a hash function which is explicitly not designed to be endian neutral. We should provide a fast hash function and be able to change it without breaking assumptions, which this is not doing. Joerg
