> On 12/28/11 5:57 PM, Alistair Crooks wrote:
> > On Thu, Dec 29, 2011 at 01:40:33AM +0000, Jeff Rizzo wrote:
> >> Module Name: src
> >> Committed By: riz
> >> Date: Thu Dec 29 01:40:32 UTC 2011
> >>
> >> Modified Files:
> >> src/lib/libperfuse: debug.c
> >>
> >> Log Message:
> >> Cast time_t to intmax_t for printf purposes, and format with %j. Fixes
> >> build on amd64 and probably i386 as well.
> > Thanks for fixing this one, Jeff.
> >
> > Any reason we're not using the PRI* definitions in<inttypes.h>?
>
> They didn't seem to add anything in this case, and muddled readability;
> am I missing something?
two things come to mind about this change:
- time_t can be a floating point type
- there's no PRI* for time_t
in general using PRI* and not casting is always a better solution.
.mrg.
