On Fri, Jan 14, 2011 at 11:22:33AM +0200, Antti Kantee wrote: > > > Remove the componentname-saving code since it was addressing > > > SAVENAME/HASBUF/SAVESTART and they don't exist anymore (and the > > > removed code didn't compile on nb5). > > > > Unfortunately, you still need that code for now, because many fses set > > flags in the componentname in lookup and expect them to still be there > > later. Depending on exactly what you were trying, this may explain > > some of the problems you've just seen with whiteouts... > > It does not explain them for quite a few reasons: > > 1) this code is not used in the whiteout tests (!!)
"depending on exactly what you were trying" > 2) the now-removed code only affected rename It looked to me like it removed all the componentname-saving code, but maybe I misread it. > 3) puffs does not support unions, making all debate of support at > the server level purely academic fair enough. > Do you have some relevant scenarios where "fses set flags in > componentname"? For example, ufs_lookup sets ISWHITEOUT, which is later checked by ufs_mkdir and ufs_create and others. -- David A. Holland dholl...@netbsd.org
