On Sat, Jul 24, 2010 at 02:03:14PM +0200, Jean-Yves Migeon wrote:
> On 24.07.2010 12:30, Manuel Bouyer wrote:
> >> How about making paddr_t always 64bit? That makes it much easier to deal
> >> with in libkvm.
> >
> > The overhead would need to be evaluated first.
> > Also, I'm not sure this would fix all the libkvm issues (the page table
> > format is still different).
>
> For the page table format, the PAE types and macros could be redefined
> with a prefix, and then aliased to the ones used in kernel when "options
> PAE" is defined.
>
> kvatop/pa2off functions could have access to both macros/typedefs, by
> just having pae_ prefixed in front (pae_pl*_pi, pae_pd_entry_t, and so
> on). It becomes a matter of calling the proper code within kvm(3), by
> checking if PAE was enabled within the kernel dump (through kvm_nlist,
> for example).
Is there other places where paddr_t is used in libkvm (AFAIK there's none) ?
If not, then there's no point in making paddr_t 64bits for plain i386 for
this issue.
--
Manuel Bouyer <bou...@antioche.eu.org>
NetBSD: 26 ans d'experience feront toujours la difference
--
