Hi, David From: David Young <dyo...@pobox.com> Subject: Re: CVS commit: src/sys/dev/pci Date: Fri, 25 Jun 2010 11:35:40 -0500
> On Fri, Jun 25, 2010 at 01:10:13PM +0900, masan...@iij.ad.jp wrote: >> >> From: SAITOH Masanobu <msai...@netbsd.org> >> Subject: CVS commit: src/sys/dev/pci >> Date: Fri, 25 Jun 2010 03:47:58 +0000 >> >> > Module Name: src >> > Committed By: msaitoh >> > Date: Fri Jun 25 03:47:57 UTC 2010 >> > >> > Modified Files: >> > src/sys/dev/pci: if_wmreg.h >> > >> > Log Message: >> > The GIO master enable bit in STATUS register is not bit 16 but bit 18. >> > It will fix a problem on 82580 SGMII system. >> >> This is wrong. I've cvs admined with the following message: >> >> The GIO master enable bit in STATUS register is not bit 16 but bit 18. >> It will fix a problem in the reset sequence on PCI-e chips. > > Is it 18 or 19? > > -#define STATUS_GIO_M_ENA (1U << 16) /* PCIX master enable */ > +#define STATUS_GIO_M_ENA (1U << 19) /* GIO master enable */ bit 19 (0x00080000). I'll cvs admin again :-| > Use __BIT(3) ? OK. I'll do it in future. > Dave > > -- > David Young OJC Technologies > dyo...@ojctech.com Urbana, IL * (217) 278-3933 ---------------------------------------------------------- SAITOH Masanobu (masan...@iij.ad.jp msai...@netbsd.org)