On Thu, Dec 17, 2009 at 01:25:11AM +0000, Mindaugas Rasiukevicius wrote: > Module Name: src > Committed By: rmind > Date: Thu Dec 17 01:25:11 UTC 2009 > > Modified Files: > src/sys/ddb: db_lwp.c > src/sys/kern: init_main.c kern_lwp.c kern_proc.c subr_prof.c > sys_process.c > src/sys/uvm: uvm_fault.c uvm_glue.c > > Log Message: > Replace few USER_TO_UAREA/UAREA_TO_USER uses, reduce sys/user.h inclusions.
Maybe it's just me, but I do find the - return USER_TO_UAREA(l->l_addr); + return (vaddr_t)l->l_addr - UAREA_USER_OFFSET; } void uvm_lwp_setuarea(lwp_t *l, vaddr_t addr) { - l->l_addr = UAREA_TO_USER(addr); + l->l_addr = (void *)(addr + UAREA_USER_OFFSET); USER_TO_UAREA/UAREA_TO_USER abstractions much more informative, especially at a first glance. Would it be possible to keep them? Regards, Alistair