On Fri, Dec 11, 2009 at 06:17:36AM +1100, matthew green wrote:
>
> Module Name: src
> Committed By: njoly
> Date: Thu Dec 10 14:58:28 UTC 2009
>
> Modified Files:
> src/sys/compat/netbsd32: netbsd32_ioctl.c
>
> Log Message:
> Make netbsd32_from_{ifreq,oifreq}() copy the whole structure, not only
> the interface name. Finally fix my own PR/39424.
>
> ok by christos.
>
>
> this uses the size of the non-compat version to copy, which leads to
> it copying beyond the allocated space doesn't it? ie, it should be:
>
> memcpy(s32p, p, sizeof *s32p);
>
> shouldn't it?
It should not be a problem as both native and compat netbsd32
ifreq/oifreq structures have the same size.
--
Nicolas Joly
Biological Software and Databanks.
Institut Pasteur, Paris.
