On Sun, May 17, 2009 at 4:59 PM, Quentin Garnier <c...@cubidou.net> wrote: > On Tue, May 12, 2009 at 11:03:25PM +0000, Elad Efrat wrote: >> Module Name: src >> Committed By: elad >> Date: Tue May 12 23:03:25 UTC 2009 >> >> Modified Files: >> src/sys/net: if_bridge.c >> >> Log Message: >> Move kauth(9) call before going into splnet(). >> >> Mailing list reference: >> >> http://mail-index.netbsd.org/tech-net/2009/05/08/msg001286.html > > So, > > 2. You don't commit the patch that you sent
True, I added the validity check of ifd_cmd as pointed out by you in: http://mail-index.netbsd.org/tech-net/2009/05/08/msg001287.html > 3. When (publicly, even) told about an obvious bug, you still go > ahead and commit it. False, the bug you're referring to wasn't the one that was fixed, see the commit diff: http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/net/if_bridge.c.diff?r1=1.68&r2=1.69&f=h Sorry for the inconvenience, -e.