Christos Zoulas wrote: > On Apr 18, 1:46pm, christoph_eg...@gmx.de (Christoph Egger) wrote: > -- Subject: Re: CVS commit: src/sys/uvm > > | This would imply to change the flags arguments of the pmap API > | from int to u_int to avoid troubles with checking flag bits. > > As it should have been in the first place, so change it.
May I propose to introduce a MI flags_t for this purpose? I would define it as typedef u_int flags_t; If this is fine, is sys/sys/types.h the right place ? If yes, should it be available in _KERNEL, in _NETBSD_SOURCE or generally ? > > | Alternatively, code like this > | > | if (flags & FLAG1) > | do_something(); > | > | must be converted to > | > | if ((flags & FLAG1) == FLAG1) > | do_something(); > > This is overkill. and error-prone as it is very likely to be forgotten. Just wanted to mention the alternative for completeness. Christoph
