On 06/22/2018 06:52 AM, Steven Jan Springl wrote:
> Hi Tom
> 
> Shorewall rule:
> 
> ACCEPT  lan:!lo  wan  icmp  8
> 
> Generates the following iptables-restore rule:
> 
> -A lan2wan -p 1 --icmp-type 8 !-i lo -j ACCEPT
> 
> Which produces the following error message:
> 
> Bad argument `!-i'
> 

Hi Steven,

Your post arrived while I was traveling, and I forgot to address it when
I returned. The attached patch should resolve this issue for you.

Thanks,
-Tom
-- 
Tom Eastep        \   Q: What do you get when you cross a mobster with
Shoreline,         \     an international standard?
Washington, USA     \ A: Someone who makes you an offer you can't
http://shorewall.org \   understand
                      \_______________________________________________
diff --git a/Shorewall/Perl/Shorewall/Chains.pm b/Shorewall/Perl/Shorewall/Chains.pm
index e1c7107c8..5b6e369d1 100644
--- a/Shorewall/Perl/Shorewall/Chains.pm
+++ b/Shorewall/Perl/Shorewall/Chains.pm
@@ -5895,7 +5895,7 @@ sub do_nfacct( $ ) {
 #
 sub match_source_dev( $;$ ) {
     my ( $interface, $nodev ) = @_;
-    my $invert       =  ( $interface =~ s/^!// ) ? '!' : '';
+    my $invert       =  ( $interface =~ s/^!// ) ? '! ' : '';
     my $interfaceref =  known_interface( $interface );
     $interface = $interfaceref->{physical} if $interfaceref;
 

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Shorewall-users mailing list
Shorewall-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shorewall-users

Reply via email to