While I was looking into JbiTask class, I see a method connect with no return
type..
i.e

org.apache.servicemix.jbi.management.task.JbiTask

    public void connect() throws IOException {

..

As per my views on right naming conventions, either this method should
return some connection object or call it as makeConnection() - if we
continue to have the return type to void.

We at TejaSoft push for having code which does not need explicit
documentation to understand and maintain. So just a thought we could share
such finding to opensource product community

Regards,
Raja Nagendra Kumar,
C.T.O
www.tejasoft





-- 
View this message in context: 
http://www.nabble.com/changes-to-function-signature..-tf4621415s12049.html#a13198295
Sent from the ServiceMix - Dev mailing list archive at Nabble.com.

Reply via email to