[ https://issues.apache.org/activemq/browse/SM-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40253 ]
Guillaume Nodet commented on SM-1082: ------------------------------------- Kristian, I don't see where the isFactoryJNDIregistered flag is set to true in this patch ... > Inconsistent exception handling in ClientFactory > ------------------------------------------------ > > Key: SM-1082 > URL: https://issues.apache.org/activemq/browse/SM-1082 > Project: ServiceMix > Issue Type: Bug > Components: servicemix-core > Reporter: Kristian Koehler > Fix For: 3.1.3, 3.2 > > Attachments: servicemix-core.patch > > > Hi > the org/apache/servicemix/jbi/framework/ClientFactory includes exception > handling code which is IMO not consistent. Within the start() method the > factory tries to bind itself to a jndi context. If this fails an warning is > logged. > Within the stop() the factory tries to unbind itself from jndi without > checking if its registered properly. > I attached a patch where it is checked if the bind was successful. If not the > stop method skips the unbind call. > Kristian -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.