[
https://issues.apache.org/activemq/browse/SM-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40214
]
Guillaume Nodet commented on SM-1081:
-------------------------------------
The overall patch looks good, thx.
I have a minor concern on the SplitAggregator patch though.
It seems like you are changing the default behavior by checking if there is a
prefix for the message wrapper element name.
As the default value has no prefix, I suppose that it won't be used by default.
So i'm removing the lines on setMessageElementName.
Did I miss something ?
> A StaticRecipientListAggregator like SplitAggregator is needed
> ---------------------------------------------------------------
>
> Key: SM-1081
> URL: https://issues.apache.org/activemq/browse/SM-1081
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-eip
> Affects Versions: 3.1.1
> Environment: ServiceMix 3.1.1
> Reporter: Andrea Zoppello
> Fix For: 3.2
>
> Attachments: RecipientListAggregator.java,
> SplitAggregator.java.patch, StaticRecipientList.java.patch
>
>
> We need a specific aggregator to use in couple with a Static recipient List.
> To do this we need to:
> 1) Modify the static recipient list to propagate some information needed to
> be used by RecipientListAggregator
> 2) Implement the RecipientListAggregator class
> 3) With a small update to SplitAggregator class RecipientListAggregator could
> simply extend SplitAggregator to reuse
> the aggregation logic. The problem is that the Expression properties are
> private, so we need to change SplitAgggregator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
