[ 
https://issues.apache.org/activemq/browse/SM-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gert Vanthienen updated SM-932:
-------------------------------

    Attachment: SM-932-http.patch

The last patch file (*-http) contains all necessary modifications for 
servicemix-http.  It also contains the updated pom.xml for the binding 
components.

Just a few remarks:
* I have used some J2SE 5.0 constructs (varargs, generics, ...) during the 
cleanup (e.g. to reduce the amount of code per method).  If you still want to 
be 1.4-compliant, these have to be modified
* SslParameters contains a call to hash(String... strings).  If I don't enclose 
the parameters to this call in a new String[] { }, PMD (incorrectly) complains 
about an unused private method

> Enable PMD/CheckStyle for binding components
> --------------------------------------------
>
>                 Key: SM-932
>                 URL: https://issues.apache.org/activemq/browse/SM-932
>             Project: ServiceMix
>          Issue Type: Task
>          Components: servicemix-file, servicemix-ftp, servicemix-http, 
> servicemix-jms, servicemix-truezip
>            Reporter: Gert Vanthienen
>            Priority: Minor
>         Attachments: SM-932-file.patch, SM-932-ftp.patch, SM-932-http.patch, 
> SM-932-jms.patch, SM-932-truezip.patch, SM-932-xmpp.patch
>
>
> PMD/CheckStyle should be enabled for binding components

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to