Gert Vanthienen wrote:
> Guillaume,
>
> Just a few questions/remarks about the CheckStyle rules:
> - a lot of the code seems to be written with a line length of 132 in
> mind, why change it to 120?
> - the rules don't allow using this way of creating setters
> public void setMBeanServer(MBeanServer mbeanServer) {
> this.mbeanServer = mbeanServer;
> }
I think it is good to do:
setMbeanServer(MBeanServer newMbeanServer) {
mbeanServer = newMbeanServer;
}
Doesn't it?
Thomas
>
> Regards,
>
> Gert Vanthienen
>
>
> Guillaume Nodet wrote:
>> Hi everybody !
>>
>> I have recently checked in lots of changes. These are mostly
>> code conventions fixes. Let me explain.
>>
>> I've started to add checkstyle and pmd checks at build time.
>> For those who do not know these tools, checkstyle
>> (http://checkstyle.sourceforge.net/) enforces
>> code conventions (braces, spaces, etc ...), while PMD
>> (http://pmd.sourceforge.net/) checks for possible bugs.
>>
>> These tools are configured in the new parent module
>> which all other modules should inherit directly or indirectly
>> when they pass these checks (the buid fails if these checks
>> do not pass).
>>
>> Currently, only the serviceengines module inherit from parent
>> so any help to migrate the other modules is welcome :-)
>> The goal is to have all modules (core, common, deployables mainly)
>> inherit from parent.
>>
>> Btw, thanks to the CXF team which did that a few months ago,
>> and where I borrowed the configuration and all ...
>>
>
>
--
Thomas Termin
_______________________________
blue elephant systems GmbH
Wollgrasweg 49
D-70599 Stuttgart
Tel : (+49) 0711 - 45 10 17 676
Fax : (+49) 0711 - 45 10 17 573
WWW : http://www.blue-elephant-systems.com
Email : [EMAIL PROTECTED]
blue elephant systems GmbH
Firmensitz : Wollgrasweg 49, D-70599 Stuttgart
Registergericht : Amtsgericht Stuttgart, HRB 24106
Geschäftsführer : Holger Dietrich, Thomas Gentsch, Joachim Hoernle
