Sure, where ? Anyway, the project works in commit-then-review (CTR) mode as opposed to review-then-commit (RTC). So feel free to commit anything you want, and if there is any problem, we can discuss it and fix / modify / enhance / revert as needed.
On 3/20/07, Thomas TERMIN <[EMAIL PROTECTED]> wrote:
Guillaume Nodet wrote: > Yeah, it should work. Even if not embedded in servicemix, > though I would prefer to avoid hard dependencies on internal > classes. The other solution is to do it with reflection, as done > in AsyncBaseLifeCycle#findExecutorFactory > > If you can try to hide this hideous cast in a common parent class, > that would be fine ;-) So I did the complete stuff with reflection. It would be nice if you would have a look at the code. > > On 3/15/07, Thomas TERMIN <[EMAIL PROTECTED]> wrote: >> >> Guillaume, >> >> can I do this? >> >> if (isComponentContextImpl(getContext().getMBeanNames())) >> { >> ComponentContextImpl contextImpl >> =(ComponentContextImpl)getContext().getMBeanNames(); >> } >> >> or is it to dirty? I would have all information then. ;-) >> >> Guillaume Nodet wrote: >> > Well, i think it will be difficult without accessing >> > ServiceMix internals. >> > Or maybe tweaking with the mbean names factory >> > available on the component context ? I don't recall what it gives ... >> > >> > On 3/14/07, Thomas TERMIN <[EMAIL PROTECTED]> wrote: >> >> >> >> Guillaume Nodet wrote: >> >> > Yeah, sounds good. >> >> > Make sure you use the facilities available on >> >> > the ComponentContext to create the mbean names ... >> >> Do you have special vision there? What I thought is to have it under >> the >> >> Type=Endpoint,SubType=Internal or External. But it seems not so easy. >> >> > If the mbean name for this interface could be related >> >> > to the endpoint name, that would make it easier to find. >> >> >> >> > >> >> > On 3/13/07, Thomas TERMIN < [EMAIL PROTECTED]> wrote: >> >> >> >> >> >> Guillaume Nodet wrote: >> >> >> > I mean, did you already implement the JMX part ? >> >> >> > Which interface are you exposing to JMX ? >> >> >> > Anyway, you should raise a JIRA ... >> >> >> I didn't implemtet it up to now. But what I want to do is expose an >> >> >> SwitchPredicateMBean interface where you can change some >> properties. >> >> >> What do you think. This could also be done for the XpathPredicate >> and >> >> so >> >> >> on. I have implemented the SwitchPredicate and doing tests at the >> >> moment. >> >> >> >> >> >> > >> >> >> > On 3/13/07, Thomas TERMIN <[EMAIL PROTECTED]> wrote: >> >> >> >> >> >> >> >> Yes of course should also be changeable via JMX. >> >> >> >> >> >> >> >> Guillaume Nodet wrote: >> >> >> >> > Well, it sounds good. >> >> >> >> > What about the JMX stuff ? >> >> >> >> > >> >> >> >> > On 3/13/07, Thomas TERMIN < [EMAIL PROTECTED]> >> wrote: >> >> >> >> >> >> >> >> >> >> Guillaume Nodet wrote: >> >> >> >> >> > On 3/12/07, Thomas TERMIN <[EMAIL PROTECTED]> >> >> wrote: >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> Peter my colleague asked if you need a switch-filter as an >> >> EIP >> >> >> >> >> >> > component. It does nothing more then check a property >> for >> >> >> message >> >> >> >> >> flow. >> >> >> >> >> >> > If this property is true it sends the message to the >> >> >> destination >> >> >> >> and >> >> >> >> >> if >> >> >> >> >> >> > it is false the exchange will be discarde. This is >> helpfull >> >> if >> >> >> >> you >> >> >> >> >> have >> >> >> >> >> >> > different installations where some services are >> >> installed or >> >> >> not >> >> >> >> >> >> > installed in servicemix. What he want to do is that you >> can >> >> >> >> >> enable or >> >> >> >> >> >> > disbale the flow via JMX as well as an property in a >> >> property >> >> >> >> >> file at >> >> >> >> >> >> > runtime. (Hope the explanation was understandable) >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> Sounds good, but I wonder wha's the difference with the >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> http://incubator.apache.org/servicemix/servicemix-eip.html#servicemix-eip-MessageFilter >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> . >> >> >> >> >> >> We only need to implement a new predicate based on >> >> properties, >> >> >> >> which >> >> >> >> >> >> could >> >> >> >> >> >> be >> >> >> >> >> >> reused by the router for example. I'm not sure if this is >> >> what >> >> >> you >> >> >> >> >> meant >> >> >> >> >> >> or not >> >> >> >> >> >> (maybe you were talking about a system property ?) >> >> >> >> >> >> As for the JMX stuff, it's a very good idea. >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> I'm still not sure if you were talking about a property on >> >> the >> >> >> JBI >> >> >> >> >> > exchange >> >> >> >> >> > or a system property. There's no predicate on message >> >> properties >> >> >> it >> >> >> >> >> > could be implemented easily (and should anyway). As I >> said, >> >> JMX >> >> >> >> >> controlled >> >> >> >> >> > routers or filters would be very useful for manually >> >> re-routing >> >> >> >> flows, >> >> >> >> >> etc >> >> >> >> >> This filter is intended just as a on/off filter. >> >> >> >> >> >> >> >> >> >> <eip:filter> >> >> >> >> >> <eip:property-predicate >> >> >> >> >> propertyResource="file:conf/feature.properties" >> >> propertyName="on"/> >> >> >> >> >> </eip:filter> >> >> >> >> >> >> >> >> >> >> So as you can see above there is a spring resourece defined >> >> and a >> >> >> >> >> property name. This property name will be read from the >> resource >> >> >> and >> >> >> >> >> >> >> can >> >> >> >> >> have the value true(on) or false(off). The property could >> also >> >> >> be an >> >> >> >> >> exchange property. The configuration would be: >> >> >> >> >> >> >> >> >> >> <eip:filter> >> >> >> >> >> <eip:property-predicate fromExchange="true" >> >> >> propertyName="on"/> >> >> >> >> >> </eip:filter> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> We implemented this just as a SwitchPredicate which just >> returns >> >> >> true >> >> >> >> or >> >> >> >> >> false depending on the property. >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> > >> >> >> >> > >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> >> >> Thomas Termin >> >> >> >> _______________________________ >> >> >> >> blue elephant systems GmbH >> >> >> >> Wollgrasweg 49 >> >> >> >> D-70599 Stuttgart >> >> >> >> >> >> >> >> Tel : (+49) 0711 - 45 10 17 676 >> >> >> >> Fax : (+49) 0711 - 45 10 17 573 >> >> >> >> WWW : http://www.blue-elephant-systems.com >> >> >> >> Email : [EMAIL PROTECTED] >> >> >> >> >> >> >> >> blue elephant systems GmbH >> >> >> >> Firmensitz : Wollgrasweg 49, D-70599 Stuttgart >> >> >> >> Registergericht : Amtsgericht Stuttgart, HRB 24106 >> >> >> >> Geschäftsführer : Holger Dietrich, Thomas Gentsch, Joachim >> Hoernle >> >> >> >> >> >> >> >> >> >> >> > >> >> >> > >> >> >> >> >> >> >> >> >> -- >> >> >> Thomas Termin >> >> >> _______________________________ >> >> >> blue elephant systems GmbH >> >> >> Wollgrasweg 49 >> >> >> D-70599 Stuttgart >> >> >> >> >> >> Tel : (+49) 0711 - 45 10 17 676 >> >> >> Fax : (+49) 0711 - 45 10 17 573 >> >> >> WWW : http://www.blue-elephant-systems.com >> >> >> Email : [EMAIL PROTECTED] >> >> >> >> >> >> blue elephant systems GmbH >> >> >> Firmensitz : Wollgrasweg 49, D-70599 Stuttgart >> >> >> Registergericht : Amtsgericht Stuttgart, HRB 24106 >> >> >> Geschäftsführer : Holger Dietrich, Thomas Gentsch, Joachim Hoernle >> >> >> >> >> >> >> >> > >> >> > >> >> >> >> >> >> -- >> >> Thomas Termin >> >> _______________________________ >> >> blue elephant systems GmbH >> >> Wollgrasweg 49 >> >> D-70599 Stuttgart >> >> >> >> Tel : (+49) 0711 - 45 10 17 676 >> >> Fax : (+49) 0711 - 45 10 17 573 >> >> WWW : http://www.blue-elephant-systems.com >> >> Email : [EMAIL PROTECTED] >> >> >> >> blue elephant systems GmbH >> >> Firmensitz : Wollgrasweg 49, D-70599 Stuttgart >> >> Registergericht : Amtsgericht Stuttgart, HRB 24106 >> >> Geschäftsführer : Holger Dietrich, Thomas Gentsch, Joachim Hoernle >> >> >> >> >> > >> > >> >> >> -- >> Thomas Termin >> _______________________________ >> blue elephant systems GmbH >> Wollgrasweg 49 >> D-70599 Stuttgart >> >> Tel : (+49) 0711 - 45 10 17 676 >> Fax : (+49) 0711 - 45 10 17 573 >> WWW : http://www.blue-elephant-systems.com >> Email : [EMAIL PROTECTED] >> >> blue elephant systems GmbH >> Firmensitz : Wollgrasweg 49, D-70599 Stuttgart >> Registergericht : Amtsgericht Stuttgart, HRB 24106 >> Geschäftsführer : Holger Dietrich, Thomas Gentsch, Joachim Hoernle >> >> > > -- Thomas Termin _______________________________ blue elephant systems GmbH Wollgrasweg 49 D-70599 Stuttgart Tel : (+49) 0711 - 45 10 17 676 Fax : (+49) 0711 - 45 10 17 573 WWW : http://www.blue-elephant-systems.com Email : [EMAIL PROTECTED] blue elephant systems GmbH Firmensitz : Wollgrasweg 49, D-70599 Stuttgart Registergericht : Amtsgericht Stuttgart, HRB 24106 Geschäftsführer : Holger Dietrich, Thomas Gentsch, Joachim Hoernle
-- Cheers, Guillaume Nodet ------------------------ Architect, LogicBlaze (http://www.logicblaze.com/) Blog: http://gnodet.blogspot.com/