Glad to hear that. I think there was a nice TODO in it ;)
Guillaume On 7/23/06, Philip Dodds <[EMAIL PROTECTED]> wrote:
I have started added checks to checkDescriptor in the DescriptorFactory :) P On 7/22/06, Guillaume Nodet <[EMAIL PROTECTED]> wrote: > > The jbi descriptor is not currently validated against the schema > and not semantically checked so if you ommit a mandatory element, > you may end with an NPE somewhere :( > This has to be fixed of course. > > Cheers, > Guillaume Nodet > > On 7/19/06, Philip Dodds <[EMAIL PROTECTED]> wrote: > > > > Thanks Grant, > > > > I wonder whether to put the validation in the installer so it throws a > > Deployment Exception that describes the fact its missing? > > > > P > > > > On 7/18/06, Grant McDonald <[EMAIL PROTECTED]> wrote: > > > > > > Philip, > > > > > > There is another issue where this was raised: SM-474. I had noticed > > that > > > this was occurring, and apparently the JBI xsd doesn't allow it to be > > > omitted. So SM-474 was raised to put in a validation on the JBI xsd > when > > > it > > > was being parsed/loaded. > > > > > > Grant > > > > > > -----Original Message----- > > > From: Philip Dodds [mailto:[EMAIL PROTECTED] > > > Sent: Wednesday, 19 July 2006 11:42 AM > > > To: servicemix-dev@geronimo.apache.org > > > Subject: Components without bootstraps > > > > > > > > > I have been going through the testcases and we have a failure in > > > > > > > org.apache.servicemix.jbi.installation.ComponentAssemblyInstallationTest > > > > > > Seems that the InstallerMBeanImpl assumes that every component must > have > > a > > > bootstrap and the test cases don't. > > > > > > Wanted to bounce this around, should we throw an exception stating > that > > > there isn't a bootstrap? > > > > > > P > > > > > > > > > > > >
