On Mon, 21 Sep 2026 08:14:55 GMT, Stefan Karlsson <[email protected]> wrote:
>> Johan Sjölen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StefanK comments and a bug fix
>
> src/hotspot/share/classfile/fieldLayoutBuilder.hpp line 311:
>
>> 309:
>> 310: template<typename T>
>> 311: int largest_layout_of(T lk) {
>
> The name of this function seems a bit off, given that it only tests one
> layout kind instance. And with that said, is this even used? It looks like
> this was supposed to be the base case, but the `largest_layout_of` function
> below doesn't use this function, but instead has its own version of it.
I looked at this again and see that the function is used. It is still true that
the code is duplicated in the two functions.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32276#discussion_r4061744018
