On Thu, 26 Feb 2026 14:25:37 GMT, r1viollet <[email protected]> wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve logging and test
>
> src/hotspot/share/jfr/periodic/jfrRedactedEvents.cpp line 118:
>
>> 116: }
>> 117:
>> 118: void JfrRedactedEvents::add_default_filters(StringArray* target, bool
>> argument) {
>
> I do not think there is a risk in adding more considering you added a
> mechanism to override these defaults.
> - certificates or even paths to certificates are not something we want to
> capture: `cert`
> - signing keys or anything containing signing: `signing`
> - encryption strings: `encryption`
> - access is also used to describe some secrets: `access`
> - Jason web tokens: `jwt`
> - <optional> bearer might be interesting to add, though it is associated to
> token, so we should be already covered.
@r1viollet We are about to integrate so we will have to deal with added
filters separately. I like to see examples. I filed a bug
https://bugs.openjdk.org/browse/JDK-8385576 to track this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29736#discussion_r3318068011
